Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Allow Truffle Dashboard to run without launching a browser window automatically #6096

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

cliffoo
Copy link
Contributor

@cliffoo cliffoo commented Jun 15, 2023

Addresses #6095

It can be useful in some environments to not want Dashboard to open in browser on start.

To test:

  • truffle dashboard --no-auto-open
  • truffle dashboard in a Truffle project with dashboard.autoOpen set in truffle-config.js

CLI value takes precedence.

@gnidan
Copy link
Contributor

gnidan commented Jun 15, 2023

For the CLI, we should just call this --no-auto-open. Or at least make it kebab-case!

@cliffoo
Copy link
Contributor Author

cliffoo commented Jun 15, 2023

Maybe just open everywhere, config and cli?

@cliffoo
Copy link
Contributor Author

cliffoo commented Jun 15, 2023

Ok --no-auto-open gets parsed as {"auto-open": false, autoOpen: false} and I'm going to assume that's a consistent behavior.

@cliffoo cliffoo changed the title Dashboard accept autoOpen option in config and CLI Dashboard accept autoOpen option in config and --no-auto-open option in CLI Jun 15, 2023
Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cliffoo!

@gnidan gnidan changed the title Dashboard accept autoOpen option in config and --no-auto-open option in CLI Allow Truffle Dashboard to run without launching a browser window automatically Jun 15, 2023
@cliffoo cliffoo merged commit 3c242ff into develop Jun 15, 2023
@cliffoo cliffoo deleted the dashboard-open branch June 15, 2023 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants