This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Edit the required apps page to display the version range of all apps #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it only the html file you need to fix or is the constants needing reworked as well to use a semver range. I remember there is a slight disconnect between the html output and the constants we hold to check versions. If they aren't changed in lockstep/same time we get these problems. |
michaeljohnbennett
suggested changes
Jul 4, 2022
|
Hey @michaeljohnbennett, Yes, it's only the HTML to fix. I didn't change the semver range version :) I'm gonna merge that, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required apps page displays only the minimum version of apps. To avoid misunderstandings, it might be better to display the maximum version as well.
Issue: #117