Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Fix/directory selection flow #226

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

xhulz
Copy link
Contributor

@xhulz xhulz commented Sep 12, 2022

PR description

ref: #194

The directory selection from option "Create new Solidity project" has moved to the end of the flow as requested by @kevinbluer and @acuarica

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if documentation updates are required.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Just made some style comments. Thanks!

src/commands/ProjectCommands.ts Show resolved Hide resolved
src/commands/ProjectCommands.ts Outdated Show resolved Hide resolved
src/commands/ProjectCommands.ts Outdated Show resolved Hide resolved
@michaeljohnbennett michaeljohnbennett merged commit 6b6086c into develop Sep 13, 2022
@michaeljohnbennett michaeljohnbennett deleted the fix/directory-selection-flow branch September 13, 2022 03:39
xhulz added a commit that referenced this pull request Oct 27, 2022
* Dedicated tab(s) in VS Code panel (#205)

* feat: implementing the new truffle panel log

* build: multi tab has been implemented

* build: dead code has been removed

* build: dispose tab and onview activation has implemented

* refactor: main.js has converted to object

* docs: ts documentation and code comments has been added

* fix: code review resolutions

* fix: required.test has been fixed

* fix: change gfx (#215)

Bryan supplied a revised logo image san's dropshadow.

* Remove redundant txns from dialog after a redeploy (#225)

fix: the debug transaction dropdown is now showing only the last deployed transaction

* New solidity project types has added: empty, sample and unbox a truffle project (#222)

* feat: new types of project were added to create a new project

* fix: folder projectPath has been vanish out

* Networks (Local Instance) - Get More Information (#217)

* feat: saving progress

* feat: saving the progress

* feat: saving the progress

* feat: it has been created the option to get details for ganache instances

* fix: problems pointed out in the code review have been fixed

Co-authored-by: MB <951378+michaeljohnbennett@users.noreply.github.com>

* Fix/directory selection flow (#226)

* feat: new types of project were added to create a new project

* fix: folder projectPath has been vanish out

* fix: the directory selection has moved to the end of the flow

* fix: truffle box sample project name variable has changed

* Dropdown when selecting a box to "unbox" (#220)

chore: the textbox has been replaced by a dropdown with the list of boxes

* Create an "auto-deploy on save" toggle in the Contract Explorer (#227)

* chore: saving the progress

* chore: status bar for auto deploy was placed on vscode environment

* chore: auto deploy action has been implemented for contracts

* fix: remove auto focus from log panel (#233)

fix: auto focus from log panel has been removed

* Fix: Debug no source file (#229)

* fix: truffle compile has been added to gather the artifacts compilation in correct way

* fix: drizzle has been removed from truffle boxes list

* docs: the typescript docs has been created

* fix: typo

* fix: pretting missing code

* fix: references no longer used have been removed

* fix: namespace from contract helpers has been removed

* fix: suggestions from code review have been implemented

* Spurious closing bracket on "Create sample project" entry when creating a new project (#238)

fix: the sample project description text has been fixed

* Temporarily continue logging to the Truffle for VS Code output channel (#237)

* chore: logging using output channels has been implemented again

* fix: auto focus has been removed from log create and log dispose

* fix: the focus on output channels has been restaured

* fix: minor stylistic tweaks to output tabs (#240)

* fix: minor stylistic tweaks to output tabs

* fix: output tab accommodations for light(er) modes

* Changelog has been updated with new features (#242)

* chore: changelog has been updated with new features

* fix: text has been changed

* Fix: original-require package issues (#243)

fix: webpack has been updated to solve the problem with original-require package

* Fix: Webpack options (#245)

fix: devtool has changed to eval instead source-map

Co-authored-by: MB <951378+michaeljohnbennett@users.noreply.github.com>
Co-authored-by: Kevin Bluer <kevin@bluer.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants