Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last action status indicator #11

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Add last action status indicator #11

merged 1 commit into from
Aug 1, 2023

Conversation

jieyouxu
Copy link
Collaborator

Screenshot 2023-07-30 223128

Closes #3.

@trumank
Copy link
Owner

trumank commented Aug 1, 2023

Nice! Couple suggestions:

  • I would display no status at all before any action has been taken, and also clear the status as soon as an action begins. Seeing "integration complete" while integration is currently happening is a bit confusing.
  • The fully saturated green and red status background is also quite harsh so I think LIGHT_GREEN and LIGHT_RED looks better.

Future thoughts

  • Add another progress state: "in progress:"
    • Would greatly simplify the "is any action currently occuring" logic
    • Let the action provide status updates e.g. "resolving mod 2 of 3: https://mod.url"
  • Add hover text or a popup window to display the entire error message if one occurs.
  • Show a checkmark or cross instead of the large "STATUS" text. I spent 30 minutes on it and couldn't get a satisfying look so I'm content with how it is now.

@jieyouxu
Copy link
Collaborator Author

jieyouxu commented Aug 1, 2023

Changes:

  • Added LastActionStatus::{Idle, Success, Failure} to handle no-last-action case and status clearing.
  • Use LIGHT_GREEN and LIGHT_RED for STATUS instead.

@trumank trumank merged commit 2b3a258 into trumank:master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show status of last action at the bottom
2 participants