-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Transition to mod profiles being composed of mod groups #30
Conversation
7349f60
to
7c90eaa
Compare
# ------------------------ >8 ------------------------ # Do not modify or remove the line above. # Everything below it will be ignored. # # Conflicts: # src/gui/mod.rs
Manually editing the `profiles.json` and `mod_groups.json` config files are prone to errors and likely will cause crashes.
I think the mod groups feature conceptually needs a lot more work before it's ready to be merged, and refactoring the current GUI logic and implementing versioned config migrations are things that should happen before then. The currently GUI logic is a sprawling mess which makes maintaining this PR a lot of work in the meantime. Here are things that should be addressed beforehand:
Once these are complete it should make implementing the rest of the mod groups feature a lot simpler. |
Makes a lot of sense to me. I would prefer to restart this PR after some GUI refactoring and versioned config land to not contribute even more mess to the current GUI. If you have some refactoring that you'd want to do, please do go ahead as I don't plan to maintain this PR (I prefer to start fresh after the refactoring due to inevitable large amounts of merge conflicts) at its current form. |
Closing since #46 is merged. |
This PR migrates the conceptual model from the simple model of mod profiles simply containing mods to a more hierarchical model of mod profiles being composed of layered mod groups. Updating a mod group in turn updates all the mod profiles which depend on it. See #14 for more context.
It also implements versioned configuration files (
config.json
,profiles.json
->mod_data.json
,cache.json
) and their migration.Pending Work
config.json
,profiles.json
->mod_data.json
,cache.json
). NEEDS TESTING.Future Work