Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Angular 13 #95

Merged
merged 10 commits into from
Mar 9, 2022
Merged

Update to Angular 13 #95

merged 10 commits into from
Mar 9, 2022

Conversation

jordanpowell88
Copy link
Contributor

I am working on a cypress project that requires Angular 12+ (Webpack 5) and wanted to use this repo for the example. Therefore this PR updates this from Angular 11 to 13

@trungvose
Copy link
Owner

Thanks @jordanpowell88 🍻 However, the CI is still failing. Could you please help to take a look?

image

@jordanpowell88
Copy link
Contributor Author

@trungk18 I am unable to see the logs to know what is wrong with the build. The netlify-build script is running fine locally.

@trungvose
Copy link
Owner

@jordanpowell88 Thanks, I'll checkout your branch and do a quick check later today. Sorry for the wait 🤣

@trungvose trungvose merged commit aab0c43 into trungvose:master Mar 9, 2022
@trungvose
Copy link
Owner

@jordanpowell88 I am trying to fix the build issue on Netlify. By the way, I also did a major refactoring on the folder structure after merging your PR, hope It didn't come as a surprise

@jordanpowell88
Copy link
Contributor Author

Thanks! I'll rebase and see what happens....YOLO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanpowell88 @trungvose