Update to Angular 13 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jordanpowell88 🍻 However, the CI is still failing. Could you please help to take a look?
|
jordanpowell88
force-pushed
the
angular-12
branch
from
421a858
to
962eb24
Compare
|
@trungk18 I am unable to see the logs to know what is wrong with the build. The |
|
@jordanpowell88 Thanks, I'll checkout your branch and do a quick check later today. Sorry for the wait 🤣 |
|
@jordanpowell88 I am trying to fix the build issue on Netlify. By the way, I also did a major refactoring on the folder structure after merging your PR, hope It didn't come as a surprise |
|
Thanks! I'll rebase and see what happens....YOLO! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a cypress project that requires Angular 12+ (Webpack 5) and wanted to use this repo for the example. Therefore this PR updates this from Angular 11 to 13