Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tflint >=0.47.0 #351

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Support tflint >=0.47.0 #351

merged 4 commits into from
Jul 6, 2023

Conversation

TylerJang27
Copy link
Collaborator

Adaptation of #350, using target: ${parent} to better achieve the --chdir behavior recommended by terraform-linters/tflint#1687

@TylerJang27 TylerJang27 mentioned this pull request Jul 5, 2023
Closed
@TylerJang27 TylerJang27 marked this pull request as ready for review July 5, 2023 19:18
@TylerJang27 TylerJang27 changed the title Support tflint v0.47.0 Support tflint >=v0.47.0 Jul 5, 2023
@TylerJang27 TylerJang27 changed the title Support tflint >=v0.47.0 Support tflint >=0.47.0 Jul 5, 2023
@TylerJang27 TylerJang27 requested review from det and laurit17 July 5, 2023 20:26
@dex4er
Copy link
Contributor

dex4er commented Jul 5, 2023

I confirm. Works great!

@TylerJang27
Copy link
Collaborator Author

Thanks again to @dex4er for identifying this and driving towards a solution!

@TylerJang27 TylerJang27 merged commit 29a913b into main Jul 6, 2023
@TylerJang27 TylerJang27 deleted the tyler/tflint-v0.47.0 branch July 6, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit17 laurit17 laurit17 approved these changes

@det det Awaiting requested review from det

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerJang27 @dex4er @laurit17