Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tool tests #795

Merged
merged 4 commits into from
May 30, 2024
Merged

Add missing tool tests #795

merged 4 commits into from
May 30, 2024

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented May 30, 2024

A number of tools were using toolInstallTest but didn't have a healthcheck, so we didn't have any real coverage. I added healthchecks when possible and a few other custom cases.

Also fixes yq not actually working

Copy link

trunk-io bot commented May 30, 2024

⏱️ 3h 18m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 1h 🟩🟩
Linter Tests macOS 44m 🟩🟩🟩
Windows Tool Tests 38m 🟥🟥🟩
Tool Tests (ubuntu-latest) 31m 🟥🟩🟥🟩
Tool Tests (macOS) 12m 🟥🟥🟩
Action Tests 4m 🟩🟩🟩
CodeQL-Build 3m 🟩🟩🟩
Trunk Check runner [linux] 3m 🟩🟩🟩
Repo Tests / Plugin Tests 1m 🟩🟩🟩
Detect changed files 20s 🟩🟩🟩
Aggregate Test Results 11s 🟥🟥🟥🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

trunk-staging-io bot commented May 30, 2024

💊 0 quarantined ✅ 245 passed 🕐 191 new ⋅ (learn more)

docs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review May 30, 2024 21:05
@TylerJang27 TylerJang27 requested a review from det May 30, 2024 21:05
@TylerJang27 TylerJang27 merged commit 1539f75 into main May 30, 2024
15 checks passed
@TylerJang27 TylerJang27 deleted the tyler/fix-tool-tests branch May 30, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants