Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rule_action_override option in managed_rule statement. #111

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Added rule_action_override option in managed_rule statement. #111

merged 3 commits into from
Apr 20, 2023

Conversation

Sanket-Rajgiri
Copy link

Added rule_action_override option in managed_rule statement.

Screenshot from 2023-03-20 20-39-43

Changes proposed in this pull request:

  • Added an option to override managed rule action for a specific list of rules and also action to use while overriding rule group action.
  • Modified example of ALB to use managed rules.

@Sanket-Rajgiri Sanket-Rajgiri mentioned this pull request Mar 20, 2023
Closed
@rpdelaney rpdelaney self-requested a review April 3, 2023 13:43
@rpdelaney
Copy link
Contributor

Hey @Sanket-Rajgiri , thanks for the pull request! I'll try to get this reviewed by the end of the week.

@rpdelaney rpdelaney self-assigned this Apr 4, 2023
@rpdelaney
Copy link
Contributor

Sorry I didn't get to this. I'm setting time to review next week. Thanks again

@rpdelaney rpdelaney merged commit bc743ee into trussworks:main Apr 20, 2023
@rpdelaney
Copy link
Contributor

Released in v2.8.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpdelaney rpdelaney Awaiting requested review from rpdelaney

Assignees

@rpdelaney rpdelaney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sanket-Rajgiri @rpdelaney