Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

feat: Issuer multi-tenancy support #55

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

rolsonquadras
Copy link
Member

closes #46

Signed-off-by: Rolson Quadras rolson.quadras@securekey.com

Signed-off-by: Rolson Quadras <rolson.quadras@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Jun 8, 2020
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #55 into master will decrease coverage by 0.00%.
The diff coverage is 88.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   88.12%   88.11%   -0.01%     
==========================================
  Files          14       15       +1     
  Lines         741      808      +67     
==========================================
+ Hits          653      712      +59     
- Misses         47       52       +5     
- Partials       41       44       +3     
Impacted Files Coverage Δ
pkg/restapi/issuer/operation/operations.go 89.47% <86.36%> (-4.65%) ⬇️
pkg/profile/issuer/profile.go 91.66% <91.66%> (ø)
cmd/adapter-rest/startcmd/start.go 82.00% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64975a...f09977d. Read the comment docs.

Copy link
Contributor

@llorllale llorllale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issuer and RP adapter's strategies for persistence has diverged. We need to get aligned. Let's discuss.

Copy link
Contributor

@llorllale llorllale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pursue NoSQL:

  • allows more agile development
  • NoSQL DBs scale out better. Although we're using MySQL as a backend store (for now), it'd be easier to switch to a native NoSQL solution if we used these K-V interfaces.
  • NoSQL DBs generally have built-in clustering support. SQL clusters are not trivially set up.
  • Team mostly has experience with NoSQL already (CouchDB)
  • Data model seems small, so the cost of duplication should be lower, allowing the use of NoSQL

Of course, there are downsides to NoSQL as well. And I don't think our data model really benefits from NoSQL.

@llorllale llorllale merged commit 538a8dd into trustbloc:master Jun 8, 2020
@rolsonquadras rolsonquadras deleted the issue-46 branch June 8, 2020 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Issuer multi-tenancy
3 participants