chore: remove OIDC server related endpoints #294
Conversation
Codecov ReportBase: 87.83% // Head: 86.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 87.83% 86.99% -0.85%
==========================================
Files 22 20 -2
Lines 2623 1992 -631
==========================================
- Hits 2304 1733 -571
+ Misses 210 165 -45
+ Partials 109 94 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ypukhta
force-pushed
the
issue-286
branch
8 times, most recently
from
6c3bd2c
to
9dbdce5
Compare
test/bdd/pkg/login/steps.go
Outdated
| err := s.registerWallet() | ||
| if err != nil { | ||
| return nil, err | ||
| // TODO TEMP FIX - find the way how to validate Sub |
There was a problem hiding this comment.
@rolsonquadras please advise how to properly validate s.wallet.UserData.Sub. What should be set at s.expectedUserData?
s.wallet.UserData.Sub is compared with s.expectedUserData inside s.userHasAuthenticatedToTheWallet().
There was a problem hiding this comment.
Do we need this test ? We removed login.feature file (used for oidc flows)
There was a problem hiding this comment.
This step is invoked from bootstrap_data_gnap.feature Should this feature file be removed as well?
There was a problem hiding this comment.
What's the endpoint getting called ? Was it deleted ? There is bootstrap data endpoint inside gnap controller as well. So, we need to refactor the call ?
ypukhta
force-pushed
the
issue-286
branch
2 times, most recently
from
af19a09
to
d4f6826
Compare
Signed-off-by: Yevgen Pukhta <eugene.pukhta@gmail.com>
Issue #286
Signed-off-by: Yevgen Pukhta eugene.pukhta@gmail.com