fix: Outbox retries forever if target domain is down #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Outbox handler now uses the AMQP Pub/Sub subsystem for retrying an unreachable domain. When a destination URL is unreachable then the AMQP message is NACK'ed and the operation is retried with a backoff and maximum number of attempts so as not to retry forever. closes trustbloc#1242 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
- Coverage 87.89% 87.87% -0.03%
==========================================
Files 171 171
Lines 17289 17290 +1
==========================================
- Hits 15197 15194 -3
- Misses 1332 1336 +4
Partials 760 760
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActivityPub Outbox now uses the AMQP Pub/Sub subsystem for retrying an unreachable domain. When a destination URL is unreachable, the AMQP message is NACK'ed and the operation is retried with a backoff and maximum number of attempts so as not to retry forever.
closes #1242
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com