feat: Add REST endpoint to deactivate/activate log URL #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
- Coverage 87.92% 87.91% -0.02%
==========================================
Files 177 178 +1
Lines 17650 17719 +69
==========================================
+ Hits 15519 15577 +58
- Misses 1361 1368 +7
- Partials 770 774 +4
Continue to review full report at Codecov.
|
bstasyszyn
reviewed
May 6, 2022
| ) | ||
|
|
||
| const ( | ||
| activateEndpoint = "/activate-log" |
There was a problem hiding this comment.
I wonder if we should have a single /log endpoint with a JSON payload that can determine the action?
There was a problem hiding this comment.
Do you mean something like:
{
"action": "activate",
"log-url": "https://vct.com/log"
}
Add REST endpoint to deactivate log URL (when it is no longer required to monitor e.g. old log). Also, add endpoint to activate log. Closes trustbloc#1276 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
bstasyszyn
approved these changes
May 9, 2022
fqutishat
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add REST endpoint to deactivate log URL (when it is no longer required to monitor e.g. old log). Also, add endpoint to activate log.
Closes #1276
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com