fix: Retry operations that fail to be re-published #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
- Coverage 87.90% 87.89% -0.02%
==========================================
Files 177 177
Lines 17650 17683 +33
==========================================
+ Hits 15516 15542 +26
- Misses 1363 1366 +3
- Partials 771 775 +4
Continue to review full report at Codecov.
|
When an operation is NACKED then the operation is re-published to the AMQP queue so that it may be retried. If the operation fails to be published (because the AMQP server is down) then the operation is detached from the current server instance, i.e. the server ID is persisted as 'detached'. The next time the operation monitor task is run, it will attempt to re-publish the operation. closes trustbloc#1289 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
fqutishat
approved these changes
May 9, 2022
sandrask
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an operation is NACKED then the operation is re-published to the AMQP queue so that it may be retried. If the operation fails to be published (because the AMQP server is down) then the operation is detached from the current server instance, i.e. the server ID is persisted as 'detached'. The next time the operation monitor task is run, it will attempt to re-publish the operation.
closes #1289
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com