fix: Make cas-url arg mandatory in orb-cli vct verify #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cas-url must be specified in order to verify the proof in the VCT log. The CAS REST endoint of Orb works with both local and IPFS CAS. Also, updated the README.md file in the tutorial to reference Read the Docs so as to avoid duplication. closes trustbloc#1305 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
- Coverage 87.93% 87.87% -0.06%
==========================================
Files 190 190
Lines 18302 18294 -8
==========================================
- Hits 16093 16075 -18
- Misses 1405 1413 +8
- Partials 804 806 +2
Continue to review full report at Codecov.
|
sandrask
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cas-url must be specified in order to verify the proof in the VCT log. The CAS REST endoint of Orb works with both local and IPFS CAS.
Also, updated the README.md file in the tutorial to reference Read the Docs so as to avoid duplication.
closes #1305
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com