Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MongoDB wrapper batch method optimization #1367

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

DRK3
Copy link
Collaborator

@DRK3 DRK3 commented Jun 21, 2022

Added an optimization that will improve performance with batch calls made to the MongoDB wrapper using keys that are known ahead of time to not already exist in the database. This optimization used to be in Orb but was lost with some recent database changes.

Signed-off-by: Derek Trider Derek.Trider@securekey.com

@cla-bot cla-bot bot added the cla-signed label Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1367 (1f41256) into main (9ad7b0a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
+ Coverage   87.74%   87.79%   +0.05%     
==========================================
  Files         199      199              
  Lines       18560    18572      +12     
==========================================
+ Hits        16285    16305      +20     
+ Misses       1461     1454       -7     
+ Partials      814      813       -1     
Impacted Files Coverage Δ
pkg/store/store.go 98.60% <100.00%> (+0.12%) ⬆️
pkg/store/wrapper/store.go 96.82% <100.00%> (ø)
...pub/service/inbox/httpsubscriber/httpsubscriber.go 97.77% <0.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad7b0a...1f41256. Read the comment docs.

Added an optimization that will improve performance with batch calls made to the MongoDB wrapper using keys that are known ahead of time to not already exist in the database. This optimization used to be in Orb but was lost with some recent database changes.

Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
@DRK3 DRK3 force-pushed the MongoDBBatchMethodReoptimization branch from dd06bf4 to 1f41256 Compare June 21, 2022 02:17
@fqutishat fqutishat merged commit 9377d19 into trustbloc:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants