Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add P-384 to protocol params #1391

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Jul 5, 2022

Add "P-384" to protocol parameters

Closes #1350

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1391 (2e6f73f) into main (6dbcaa0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1391   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         205      205           
  Lines       19094    19094           
=======================================
  Hits        16802    16802           
  Misses       1473     1473           
  Partials      819      819           
Impacted Files Coverage Δ
...g/protocolversion/versions/v1_0/config/protocol.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbcaa0...2e6f73f. Read the comment docs.

Add "P-384" to protocol parameters

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask merged commit 59d14db into trustbloc:main Jul 5, 2022
sandrask added a commit to sandrask/orb that referenced this pull request Jul 5, 2022
Add new tests that will:
1. create did, rotate log, update did and check for updated did in rotated log
2. create, update, recover and deactivate did after log rotation and check existence in rotated log

Closes trustbloc#1391

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P384 should be allowed in protocol parameters
3 participants