Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly dealing with late publishing based on witness timestamps #1394

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Jul 7, 2022

… timestamps

Check VC timestamp against witness timestamp.

Closes #1336

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Jul 7, 2022
@sandrask sandrask changed the title feat: Properly dealing with late publishing based on multiple witness… wip: Properly dealing with late publishing based on witness timestamps Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1394 (8325616) into main (59d14db) will decrease coverage by 0.02%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##             main    #1394      +/-   ##
==========================================
- Coverage   88.02%   88.00%   -0.03%     
==========================================
  Files         205      205              
  Lines       19094    19113      +19     
==========================================
+ Hits        16808    16820      +12     
- Misses       1466     1474       +8     
+ Partials      820      819       -1     
Impacted Files Coverage Δ
pkg/anchor/handler/proof/handler.go 77.95% <97.22%> (+4.50%) ⬆️
cmd/orb-server/startcmd/params.go 82.23% <100.00%> (+0.10%) ⬆️
cmd/orb-server/startcmd/start.go 67.31% <100.00%> (-0.11%) ⬇️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 88.88% <0.00%> (-8.89%) ⬇️
pkg/observer/pubsub.go 94.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d14db...8325616. Read the comment docs.

@sandrask sandrask force-pushed the issue-1336-new branch 2 times, most recently from e2ffe92 to 9a3ab9f Compare July 12, 2022 17:39
… timestamps

Check VC timestamp against witness timestamp.

Closes trustbloc#1336

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask changed the title wip: Properly dealing with late publishing based on witness timestamps Properly dealing with late publishing based on witness timestamps Jul 12, 2022
@fqutishat fqutishat merged commit b90b076 into trustbloc:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly dealing with late publishing based on multiple witness timestamps
3 participants