Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for lost DIDs after domain down for long period #1397

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

bstasyszyn
Copy link
Contributor

  • Don't use the expiry service to expire DID operations in the operation-queue. Instead, delete the operations after they fail to be delivered after the configured number of retries.
  • Increase the default value for max redelivery attempts and max interval so that retries occur for an extended period of time

closes #1395
closes #1396

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

- Don't use the expiry service to expire DID operations in the operation-queue. Instead, delete the operations after they fail to be delivered after the configured number of retries.
- Increase the default value for max redelivery attempts and max interval so that retries occur for an extended period of time

closes trustbloc#1395
closes trustbloc#1396

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@b90b076). Click here to learn what that means.
The diff coverage is 91.30%.

@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage        ?   88.05%           
=======================================
  Files           ?      205           
  Lines           ?    19092           
  Branches        ?        0           
=======================================
  Hits            ?    16811           
  Misses          ?     1462           
  Partials        ?      819           
Impacted Files Coverage Δ
pkg/store/didanchor/store.go 92.85% <75.00%> (ø)
pkg/anchor/witness/policy/inspector/inspector.go 95.91% <88.88%> (ø)
cmd/orb-server/startcmd/params.go 82.11% <100.00%> (ø)
cmd/orb-server/startcmd/start.go 67.60% <100.00%> (ø)
pkg/activitypub/service/inbox/inbox.go 91.05% <100.00%> (ø)
pkg/activitypub/service/outbox/outbox.go 89.77% <100.00%> (ø)
pkg/anchor/handler/proof/handler.go 77.95% <100.00%> (ø)
pkg/context/opqueue/opqueue.go 81.58% <100.00%> (ø)
pkg/observer/pubsub.go 94.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90b076...6332534. Read the comment docs.

@fqutishat fqutishat merged commit 7bf7114 into trustbloc:main Jul 13, 2022
@bstasyszyn bstasyszyn deleted the 1395 branch July 18, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proofs are lost if requesting domain is down Operations in queue are deleted after domain down for long time
3 participants