refactor: Remove hard-coded URLs from BDD tests #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor BDD tests to remove hard-coded URLs for local host mappings, anchor origins. Also use variables in the feature files instead of repeating the entire URL multiple times. closes trustbloc#1420 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
==========================================
+ Coverage 87.95% 88.00% +0.05%
==========================================
Files 206 206
Lines 19221 19227 +6
==========================================
+ Hits 16905 16920 +15
+ Misses 1484 1477 -7
+ Partials 832 830 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fqutishat
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor BDD tests to remove hard-coded URLs for local host mappings, anchor origins. Also use variables in the feature files instead of repeating the entire URL many times.
closes #1420
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com