Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid VC for JWS signature #1436

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix: Invalid VC for JWS signature #1436

merged 1 commit into from
Aug 22, 2022

Conversation

bstasyszyn
Copy link
Contributor

The proof for VC now uses the jws field for VCs signed with JsonWebSignature2020. Strict validation was enabled for VC verification.

Also, updated the JSON-LD context for AnchorCredential.

closes #1435

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

The proof for VC now uses the jws field for VCs signed with JsonWebSignature2020. Strict validation was enabled for VC verification.

Also, updated the JSON-LD context for AnchorCredential.

closes trustbloc#1435

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1436 (f5c0fe9) into main (c03aff7) will decrease coverage by 0.07%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   87.93%   87.86%   -0.08%     
==========================================
  Files         208      208              
  Lines       19559    19567       +8     
==========================================
- Hits        17200    17193       -7     
- Misses       1503     1516      +13     
- Partials      856      858       +2     
Impacted Files Coverage Δ
pkg/activitypub/vocab/vocab.go 100.00% <ø> (ø)
pkg/vcsigner/signer.go 89.10% <80.00%> (+1.48%) ⬆️
pkg/activitypub/vocab/contextproperty.go 95.91% <100.00%> (ø)
pkg/anchor/builder/builder.go 100.00% <100.00%> (ø)
pkg/anchor/handler/credential/handler.go 78.18% <100.00%> (+0.13%) ⬆️
pkg/anchor/handler/proof/handler.go 77.77% <100.00%> (+0.19%) ⬆️
pkg/anchor/writer/writer.go 87.92% <100.00%> (+0.02%) ⬆️
pkg/observer/observer.go 83.62% <100.00%> (+0.05%) ⬆️
pkg/vct/vct.go 86.46% <100.00%> (ø)
...pub/service/inbox/httpsubscriber/httpsubscriber.go 88.88% <0.00%> (-8.89%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sandrask sandrask merged commit 17aec9f into trustbloc:main Aug 22, 2022
@bstasyszyn bstasyszyn deleted the 1435 branch August 22, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid proof in anchor credential for JsonWebSignature2020
3 participants