Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change credentialSubject in AnchorCredential to use fields defined in a link relation #1453

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

bstasyszyn
Copy link
Contributor

Added fields to credentialSubject:

  • anchor
  • profile
  • href
  • rel
  • type

closes #1451

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1453 (32dd19c) into main (11913d1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
+ Coverage   87.88%   87.90%   +0.02%     
==========================================
  Files         208      208              
  Lines       19662    19679      +17     
==========================================
+ Hits        17279    17298      +19     
+ Misses       1522     1521       -1     
+ Partials      861      860       -1     
Impacted Files Coverage Δ
...nkset/generator/didorbgenerator/didorbgenerator.go 81.87% <100.00%> (+3.25%) ⬆️
pkg/anchor/builder/builder.go 100.00% <100.00%> (ø)
pkg/anchor/util/util.go 87.50% <100.00%> (ø)
pkg/observer/pubsub.go 94.49% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…ned in a link relation

Added fields to credentialSubject:

- anchor
- profile
- href
- rel
- type

closes trustbloc#1451

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn merged commit b08eed0 into trustbloc:main Aug 26, 2022
@bstasyszyn bstasyszyn deleted the 1451 branch August 26, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change credentialSubject in AnchorCredential to use fields defined in a link relation
3 participants