Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove dependency on edge-core cmdutils #1494

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

bstasyszyn
Copy link
Contributor

Moved the command utility functions to an internal package in orb.

closes #1492

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

Moved the command utility functions to an internal package in orb.

closes trustbloc#1492

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 87.96% // Head: 87.97% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9924801) compared to base (e3b5dd2).
Patch coverage: 96.03% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   87.96%   87.97%           
=======================================
  Files         210      211    +1     
  Lines       19824    19862   +38     
=======================================
+ Hits        17438    17473   +35     
- Misses       1524     1525    +1     
- Partials      862      864    +2     
Impacted Files Coverage Δ
internal/pkg/cmdutil/cmdutil.go 84.21% <84.21%> (ø)
cmd/orb-cli/common/common.go 73.25% <85.71%> (ø)
cmd/orb-cli/updatedidcmd/updatedid.go 89.37% <92.30%> (ø)
cmd/orb-cli/recoverdidcmd/recoverdid.go 87.15% <92.85%> (ø)
cmd/orb-cli/acceptlistcmd/getcmd.go 86.66% <100.00%> (ø)
cmd/orb-cli/acceptlistcmd/updatecmd.go 93.54% <100.00%> (ø)
cmd/orb-cli/allowedoriginscmd/getcmd.go 91.30% <100.00%> (ø)
cmd/orb-cli/allowedoriginscmd/updatecmd.go 92.72% <100.00%> (ø)
cmd/orb-cli/common/activitypubclient.go 85.71% <100.00%> (ø)
cmd/orb-cli/createdidcmd/createdid.go 91.85% <100.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bstasyszyn bstasyszyn merged commit b45546e into trustbloc:main Sep 21, 2022
@bstasyszyn bstasyszyn deleted the 1492 branch September 21, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on edge-core cmd utils
3 participants