Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove dependency on edge-core tlsutils #1495

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

bstasyszyn
Copy link
Contributor

Moved tlsutils functions to internal orb package.

closes #1493

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

Moved tlsutils functions to internal orb package.

closes trustbloc#1493

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 87.95% // Head: 87.92% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (19d39cd) compared to base (b45546e).
Patch coverage: 82.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1495      +/-   ##
==========================================
- Coverage   87.95%   87.92%   -0.03%     
==========================================
  Files         211      213       +2     
  Lines       19862    19947      +85     
==========================================
+ Hits        17470    17539      +69     
- Misses       1527     1535       +8     
- Partials      865      873       +8     
Impacted Files Coverage Δ
cmd/orb-driver/startcmd/start.go 48.24% <0.00%> (ø)
internal/pkg/tlsutil/tlsutil.go 75.00% <75.00%> (ø)
internal/pkg/tlsutil/certpool.go 82.60% <82.60%> (ø)
cmd/orb-cli/common/common.go 73.25% <100.00%> (ø)
cmd/orb-cli/createdidcmd/createdid.go 91.85% <100.00%> (ø)
cmd/orb-cli/deactivatedidcmd/deactivatedid.go 91.07% <100.00%> (ø)
cmd/orb-cli/ipfskeygencmd/keygen.go 74.31% <100.00%> (ø)
...d/orb-cli/ipnshostmetagencmd/ipnshostmetagencmd.go 90.90% <100.00%> (ø)
cmd/orb-cli/recoverdidcmd/recoverdid.go 87.15% <100.00%> (ø)
cmd/orb-cli/resolvedidcmd/resolvedid.go 84.88% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bstasyszyn bstasyszyn merged commit ba7b0cb into trustbloc:main Sep 22, 2022
@bstasyszyn bstasyszyn deleted the 1493 branch September 22, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on edge-core tls utils
3 participants