Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Caller for common logs is always the common.go file #1506

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

bstasyszyn
Copy link
Contributor

The caller log field was always set to common.log for the common log fields. This commit increases the caller skip for these logs.

Also, implemented structured logging for remaining packages.

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

The caller log field was always set to common.log for the common log fields. This commit increases the caller skip for these logs.

Also, implemented structured logging for remaining packages.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 87.89% // Head: 88.21% // Increases project coverage by +0.32% 🎉

Coverage data is based on head (4070d75) compared to base (0b4898c).
Patch coverage: 64.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   87.89%   88.21%   +0.32%     
==========================================
  Files         217      217              
  Lines       20636    20651      +15     
==========================================
+ Hits        18137    18218      +81     
+ Misses       1614     1548      -66     
  Partials      885      885              
Impacted Files Coverage Δ
cmd/orb-cli/common/common.go 73.25% <0.00%> (ø)
cmd/orb-cli/main.go 77.77% <0.00%> (ø)
cmd/orb-driver/startcmd/start.go 48.24% <0.00%> (ø)
cmd/orb-server/main.go 77.77% <0.00%> (ø)
pkg/activitypub/client/client.go 85.28% <0.00%> (ø)
pkg/activitypub/resthandler/activityhandler.go 93.69% <0.00%> (ø)
pkg/activitypub/resthandler/referencehandler.go 91.83% <0.00%> (ø)
...ctivitypub/service/activityhandler/inboxhandler.go 83.38% <0.00%> (ø)
pkg/anchor/writer/writer.go 87.94% <0.00%> (ø)
pkg/cas/resolver/resolver.go 88.95% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fqutishat fqutishat merged commit ae3d2ba into trustbloc:main Oct 4, 2022
@bstasyszyn bstasyszyn deleted the structuredlog7 branch October 4, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants