Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename StructuredLog to Log and remove SugaredLogger #1507

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

bstasyszyn
Copy link
Contributor

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 88.12% // Head: 88.12% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (fb58d66) compared to base (66e358d).
Patch coverage: 96.26% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
- Coverage   88.12%   88.12%   -0.01%     
==========================================
  Files         218      218              
  Lines       20785    20782       -3     
==========================================
- Hits        18317    18314       -3     
  Misses       1578     1578              
  Partials      890      890              
Impacted Files Coverage Δ
cmd/orb-cli/common/common.go 73.25% <ø> (ø)
cmd/orb-cli/main.go 77.77% <ø> (ø)
cmd/orb-driver/startcmd/start.go 48.24% <ø> (ø)
cmd/orb-server/main.go 77.77% <ø> (ø)
cmd/orb-server/startcmd/start.go 67.93% <ø> (ø)
internal/pkg/log/fields.go 98.73% <0.00%> (-0.63%) ⬇️
internal/pkg/log/logger.go 96.47% <0.00%> (+0.99%) ⬆️
internal/pkg/tlsutil/certpool.go 82.60% <ø> (ø)
pkg/activitypub/client/client.go 85.28% <ø> (ø)
pkg/activitypub/client/transport/transport.go 87.87% <ø> (ø)
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bstasyszyn bstasyszyn marked this pull request as draft October 5, 2022 12:15
@bstasyszyn bstasyszyn marked this pull request as ready for review October 6, 2022 15:20
Also renamed log fields to use camel-case since they are used as JSON field names.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn merged commit efd0bb9 into trustbloc:main Oct 6, 2022
@bstasyszyn bstasyszyn deleted the structuredlog8 branch October 6, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants