Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Execute pooled MQ handler in separate Go routine #1553

Merged
merged 1 commit into from
May 4, 2023

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented May 4, 2023

Handlers for pooled subscribers are each executed in a separate Go routine.

Also fixed a race condition in the errors util.

closes #1552

Handlers for pooled subscribers are each executed in a separate Go routine.

closes trustbloc#1552

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (28d0504) 88.22% compared to head (aa50918) 88.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
- Coverage   88.22%   88.22%   -0.01%     
==========================================
  Files         226      226              
  Lines       21108    21132      +24     
==========================================
+ Hits        18623    18644      +21     
- Misses       1591     1593       +2     
- Partials      894      895       +1     
Impacted Files Coverage Δ
pkg/activitypub/service/inbox/inbox.go 91.20% <100.00%> (ø)
pkg/activitypub/service/outbox/outbox.go 91.09% <100.00%> (ø)
pkg/context/opqueue/opqueue.go 81.60% <100.00%> (ø)
pkg/errors/errors.go 100.00% <100.00%> (ø)
pkg/observer/pubsub.go 93.06% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bstasyszyn bstasyszyn merged commit 6c9a8d3 into trustbloc:main May 4, 2023
12 checks passed
@bstasyszyn bstasyszyn deleted the 1552 branch May 4, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQ handlers using pooled subscriber should be executed in separate Go routine
2 participants