Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Limit the number of documents deleted per batch #1555

Merged
merged 1 commit into from
May 5, 2023

Conversation

bstasyszyn
Copy link
Contributor

closes #1549

closes trustbloc#1549

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 65.00% and project coverage change: +0.01 🎉

Comparison is base (c4fd3f2) 88.21% compared to head (74d769f) 88.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1555      +/-   ##
==========================================
+ Coverage   88.21%   88.23%   +0.01%     
==========================================
  Files         226      226              
  Lines       21168    21181      +13     
==========================================
+ Hits        18673    18688      +15     
+ Misses       1601     1599       -2     
  Partials      894      894              
Impacted Files Coverage Δ
pkg/store/expiry/expiry.go 83.56% <65.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bstasyszyn bstasyszyn merged commit ff8a874 into trustbloc:main May 5, 2023
@bstasyszyn bstasyszyn deleted the 1549 branch May 5, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB expiry service attempting to delete too many documents at once
1 participant