feat: Background refresh of actor/public key cache #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ActivityPub actor and public key caches are refreshed in the background so as not to affect the performance of a client call. If the refresh fails (due to the server being down) then the old value continues to be used. closes trustbloc#1551 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
==========================================
+ Coverage 88.21% 88.28% +0.07%
==========================================
Files 226 227 +1
Lines 21186 21367 +181
==========================================
+ Hits 18689 18864 +175
- Misses 1602 1606 +4
- Partials 895 897 +2
☔ View full report in Codecov by Sentry. |
fqutishat
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActivityPub actor and public key caches are refreshed in the background so as not to affect the performance of a client call. If the refresh fails (due to the server being down) then the old value continues to be used.
closes #1551