fix: Return HTTP 400 for missing ID in request #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return HTTP 400 (bad request) instead of 500 (internal server error) for a REST request that's missing the object ID. closes trustbloc#777 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
fqutishat
approved these changes
Sep 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #779 +/- ##
=======================================
Coverage 89.98% 89.98%
=======================================
Files 137 137
Lines 11582 11588 +6
=======================================
+ Hits 10422 10428 +6
Misses 716 716
Partials 444 444
Continue to review full report at Codecov.
|
sandrask
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return HTTP 400 (bad request) instead of 500 (internal server error) for a REST request that's missing the object ID.
closes #777
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com