Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return alternate links in WebFinger for DID and CAS #781

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Sep 17, 2021

Implemented an anchor acknowledgement handler that stores additional links for anchor credentials from domains that returned a "Like" activity. These additional links are returned in WebFinger queries for DIDs and CAS.

closes #766

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #781 (7b6c41e) into main (107e3f4) will decrease coverage by 0.14%.
The diff coverage is 84.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   89.97%   89.83%   -0.15%     
==========================================
  Files         137      139       +2     
  Lines       11614    11795     +181     
==========================================
+ Hits        10450    10596     +146     
- Misses        718      738      +20     
- Partials      446      461      +15     
Impacted Files Coverage Δ
pkg/observer/observer.go 82.19% <60.00%> (-3.20%) ⬇️
pkg/discovery/endpoint/restapi/operations.go 88.92% <79.36%> (-2.16%) ⬇️
cmd/orb-server/startcmd/start.go 73.52% <91.66%> (+0.10%) ⬆️
pkg/anchor/linkstore/linkstore.go 93.84% <93.84%> (ø)
...ctivitypub/service/activityhandler/inboxhandler.go 87.19% <100.00%> (-0.33%) ⬇️
...g/anchor/handler/acknowlegement/acknowledgement.go 100.00% <100.00%> (ø)
pkg/cas/ipfs/ipfs.go 86.08% <100.00%> (-0.24%) ⬇️
pkg/hashlink/hashlink.go 93.79% <100.00%> (+0.63%) ⬆️
pkg/store/cas/cas.go 86.76% <100.00%> (-0.38%) ⬇️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 90.12% <0.00%> (-9.88%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 107e3f4...7b6c41e. Read the comment docs.

Implemented an anchor acknowledgement handler that stores additional links for anchor credentials from domains that returned a "Like" activity. These additional links are returned in WebFinger queries for DIDs and CAS.

closes trustbloc#766

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn changed the title wip: Return alternate links in WebFinger for DID and CAS feat: Return alternate links in WebFinger for DID and CAS Sep 17, 2021
@bstasyszyn bstasyszyn merged commit 8820a16 into trustbloc:main Sep 17, 2021
@bstasyszyn bstasyszyn deleted the 766 branch September 17, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement AnchorEventAcknowledgementHandler
3 participants