Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle 'Undo' Like activity #783

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

bstasyszyn
Copy link
Contributor

A handler was added to undo a previous Like of an anchor credential. The handler removes all alternate links for the anchor that were previously added by the 'Like' handler.

closes #765

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #783 (bcc18c1) into main (2f247e6) will decrease coverage by 0.04%.
The diff coverage is 95.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   90.01%   89.96%   -0.05%     
==========================================
  Files         140      140              
  Lines       11818    11859      +41     
==========================================
+ Hits        10638    10669      +31     
- Misses        725      733       +8     
- Partials      455      457       +2     
Impacted Files Coverage Δ
...ctivitypub/service/activityhandler/inboxhandler.go 87.06% <80.00%> (-0.14%) ⬇️
...g/anchor/handler/acknowlegement/acknowledgement.go 100.00% <100.00%> (ø)
pkg/anchor/linkstore/linkstore.go 95.12% <100.00%> (+1.27%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 90.12% <0.00%> (-9.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f247e6...bcc18c1. Read the comment docs.

A handler was added to undo a previous Like of an anchor credential. The handler removes all alternate links for the anchor that were previously added by the 'Like' handler.

closes trustbloc#765

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn merged commit b28e568 into trustbloc:main Sep 21, 2021
@bstasyszyn bstasyszyn deleted the 765 branch September 21, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handler for undo Like
3 participants