Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Post one "Like" activity with multiple URIs in "to" field #787

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

bstasyszyn
Copy link
Contributor

Instead of posting two "Like" activities, post one activity with multiple URIs in the "to" field.

Also:

  • Fix the WebFinger CAS query to return 400 (bad request) instead of 500 in the CID isn't in the request.
  • Added more logging in BDD test to also log the error message.

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

Instead of posting two "Like" activities, post one activity with multiple URIs in the "to" field.

Also:
- Fix the WebFinger CAS query to return 400 (bad request) instead of 500 in the CID isn't in the request.
- Added more logging in BDD test to also log the error message.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #787 (ad11199) into main (b85cf8d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   89.92%   89.93%   +0.01%     
==========================================
  Files         140      139       -1     
  Lines       11864    11856       -8     
==========================================
- Hits        10669    10663       -6     
+ Misses        737      736       -1     
+ Partials      458      457       -1     
Impacted Files Coverage Δ
pkg/discovery/endpoint/restapi/operations.go 92.65% <100.00%> (+0.10%) ⬆️
pkg/observer/observer.go 83.24% <100.00%> (+1.04%) ⬆️
cmd/orb-server/startcmd/params.go 80.65% <0.00%> (-0.23%) ⬇️
pkg/ldcontextrest/ldcontextrest.go
cmd/orb-server/startcmd/start.go 73.78% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85cf8d...ad11199. Read the comment docs.

@fqutishat fqutishat merged commit 3bc4c6b into trustbloc:main Sep 22, 2021
@bstasyszyn bstasyszyn deleted the onepostforlike branch June 30, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants