feat: Add remote resolver #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #791 +/- ##
==========================================
+ Coverage 89.93% 90.00% +0.06%
==========================================
Files 140 141 +1
Lines 11888 11931 +43
==========================================
+ Hits 10691 10738 +47
+ Misses 738 733 -5
- Partials 459 460 +1
Continue to review full report at Codecov.
|
Add component that will be able to issue server to server call for document resolution. Closes trustbloc#790 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
fqutishat
approved these changes
Sep 23, 2021
bstasyszyn
approved these changes
Sep 23, 2021
|
|
||
| err = json.Unmarshal(responseBytes, &respObj) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to unmarshal resolution result[%s] for remote request[%s]", |
There was a problem hiding this comment.
In this case maybe the error can be added to errMsgs and continue to the next URL.
There was a problem hiding this comment.
sure, I will change this in my next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component that will be able to issue server to server call for document resolution.
Closes #790
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com