feat: NodeInfo memory usage optimization when using MongoDB #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRK3
force-pushed
the
NodeInfoMemoryUsageOptimization
branch
from
eda13cc
to
22f39cc
Compare
Codecov Report
@@ Coverage Diff @@
## main #800 +/- ##
==========================================
- Coverage 89.92% 89.91% -0.02%
==========================================
Files 141 141
Lines 12032 12154 +122
==========================================
+ Hits 10820 10928 +108
- Misses 747 758 +11
- Partials 465 468 +3
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
NodeInfoMemoryUsageOptimization
branch
6 times, most recently
from
18cc016
to
ee02723
Compare
DRK3
force-pushed
the
NodeInfoMemoryUsageOptimization
branch
2 times, most recently
from
f6397a7
to
821d272
Compare
fqutishat
approved these changes
Oct 6, 2021
sandrask
approved these changes
Oct 6, 2021
bstasyszyn
reviewed
Oct 6, 2021
| @@ -83,7 +83,8 @@ func (h *handler) handleCreateActivity(create *vocab.ActivityType) error { | |||
|
|
|||
| logger.Debugf("[%s] Storing anchor credential reference [%s]", h.ServiceName, target.Object().ID()) | |||
|
|
|||
| err := h.store.AddReference(store.AnchorCredential, target.Object().ID().URL(), h.ServiceIRI) | |||
| err := h.store.AddReference(store.AnchorCredential, target.Object().ID().URL(), h.ServiceIRI, | |||
| store.WithActivityType(create.Type().Types()[0])) | |||
There was a problem hiding this comment.
This isn't a Create type. We shouldn't have a tag here.
Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
NodeInfoMemoryUsageOptimization
branch
from
821d272
to
a477636
Compare
bstasyszyn
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Trider Derek.Trider@securekey.com