Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Support the AnchorEvent model in latest spec #801

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Oct 5, 2021

closes #674
closes #611

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #801 (c142bfe) into main (48ee87d) will decrease coverage by 0.37%.
The diff coverage is 87.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
- Coverage   89.91%   89.53%   -0.38%     
==========================================
  Files         141      141              
  Lines       12154    12323     +169     
==========================================
+ Hits        10928    11034     +106     
- Misses        758      795      +37     
- Partials      468      494      +26     
Impacted Files Coverage Δ
pkg/activitypub/store/spi/spi.go 25.00% <ø> (ø)
pkg/anchor/anchorevent/generator/generator.go 100.00% <ø> (ø)
pkg/store/didanchor/store.go 95.23% <0.00%> (-4.77%) ⬇️
...tivitypub/service/activityhandler/outboxhandler.go 85.93% <63.63%> (-6.49%) ⬇️
...ctivitypub/service/activityhandler/inboxhandler.go 85.22% <70.67%> (-1.94%) ⬇️
pkg/anchor/util/util.go 60.00% <75.00%> (-24.00%) ⬇️
pkg/orbclient/client.go 87.50% <75.00%> (-1.98%) ⬇️
pkg/anchor/handler/credential/handler.go 84.12% <77.41%> (-5.35%) ⬇️
pkg/anchor/anchorevent/anchorevent.go 80.31% <80.31%> (ø)
pkg/anchor/graph/graph.go 83.33% <84.21%> (+0.72%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ee87d...c142bfe. Read the comment docs.

@bstasyszyn bstasyszyn changed the title chore: Refactor to support the AnchorEvent model in latest spec refactor: Support the AnchorEvent model in latest spec Oct 5, 2021
@bstasyszyn bstasyszyn marked this pull request as draft October 6, 2021 20:57
@bstasyszyn bstasyszyn marked this pull request as ready for review October 7, 2021 18:21
Also change the 'not found' error in the IPFS client to persistent so that the Observer doesn't retry processing a non-existent anchor forever.

closes trustbloc#674

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity Pub changes for HandleAnchorCredential Re-visit naming on anchor activity
3 participants