Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "generator" field to AnchorObject #815

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

bstasyszyn
Copy link
Contributor

A "generator" field was added to AnchorObject so that the format of ContentObject may be identified. The code behind building ContentObject was refactored such that ContentObject builders are registered against a generator ID, namespace and version.

closes #806

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #815 (f551a00) into main (562cc96) will decrease coverage by 0.20%.
The diff coverage is 82.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   89.58%   89.38%   -0.21%     
==========================================
  Files         142      143       +1     
  Lines       12425    12496      +71     
==========================================
+ Hits        11131    11169      +38     
- Misses        798      818      +20     
- Partials      496      509      +13     
Impacted Files Coverage Δ
pkg/activitypub/vocab/util.go 77.77% <47.05%> (-9.73%) ⬇️
pkg/activitypub/vocab/objecttype.go 84.87% <60.00%> (-1.10%) ⬇️
pkg/anchor/handler/proof/handler.go 84.21% <63.63%> (-2.83%) ⬇️
...event/generator/didorbgenerator/didorbgenerator.go 83.80% <83.80%> (ø)
pkg/activitypub/vocab/anchoreventtype.go 91.73% <88.23%> (-4.94%) ⬇️
pkg/anchor/anchorevent/anchorevent.go 78.33% <90.47%> (-1.99%) ⬇️
pkg/activitypub/vocab/options.go 97.84% <100.00%> (+0.04%) ⬆️
pkg/activitypub/vocab/vocab.go 100.00% <100.00%> (ø)
.../anchor/anchorevent/generator/generatorregistry.go 100.00% <100.00%> (ø)
pkg/anchor/writer/writer.go 91.59% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562cc96...f551a00. Read the comment docs.

A "generator" field was added to AnchorObject so that the format of ContentObject may be identified. The code behind building ContentObject was refactored such that ContentObject builders are registered against a generator ID, namespace and version.

closes trustbloc#806

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@fqutishat fqutishat merged commit 73942db into trustbloc:main Oct 14, 2021
@bstasyszyn bstasyszyn deleted the 806 branch October 14, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "generator" property to AnchorObject
3 participants