Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Check document and commitments for equality instead of full re… #817

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

sandrask
Copy link
Contributor

…solution result

Check document and commitments for equality instead of full resolution result.

Closes #816

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

…solution result

Check document and commitments for equality instead of full resolution result.

Closes trustbloc#816

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #817 (5c3ec86) into main (ef3a493) will decrease coverage by 0.12%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   89.56%   89.44%   -0.13%     
==========================================
  Files         143      144       +1     
  Lines       12502    12602     +100     
==========================================
+ Hits        11198    11272      +74     
- Misses        807      821      +14     
- Partials      497      509      +12     
Impacted Files Coverage Δ
pkg/activitypub/vocab/util.go 77.77% <47.05%> (-9.73%) ⬇️
pkg/activitypub/vocab/objecttype.go 84.87% <60.00%> (-1.10%) ⬇️
pkg/anchor/handler/proof/handler.go 84.21% <63.63%> (-2.83%) ⬇️
...event/generator/didorbgenerator/didorbgenerator.go 83.80% <83.80%> (ø)
pkg/activitypub/vocab/anchoreventtype.go 91.73% <88.23%> (-4.94%) ⬇️
pkg/anchor/anchorevent/anchorevent.go 78.33% <90.47%> (-1.99%) ⬇️
pkg/activitypub/vocab/options.go 97.84% <100.00%> (+0.04%) ⬆️
pkg/activitypub/vocab/vocab.go 100.00% <100.00%> (ø)
.../anchor/anchorevent/generator/generatorregistry.go 100.00% <100.00%> (ø)
pkg/anchor/writer/writer.go 91.59% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73942db...5c3ec86. Read the comment docs.

@fqutishat fqutishat merged commit 3980f47 into trustbloc:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check document and commitments for equality instead of full resolution result
3 participants