feat: Parameters for unpublished op lifespan and expiry service interval #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #818 +/- ##
==========================================
- Coverage 89.56% 89.50% -0.07%
==========================================
Files 143 144 +1
Lines 12502 12588 +86
==========================================
+ Hits 11198 11267 +69
- Misses 807 813 +6
- Partials 497 508 +11
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
ParametersForUnpublishedOperationLifespanAndExpiredDataCheckInterval
branch
3 times, most recently
from
d45e890
to
3036271
Compare
bstasyszyn
approved these changes
Oct 15, 2021
cmd/orb-server/startcmd/params.go
Outdated
| @@ -28,6 +28,8 @@ const ( | |||
| defaultNodeInfoRefreshInterval = 15 * time.Second | |||
| defaultIPFSTimeout = 20 * time.Second | |||
| defaultDatabaseTimeout = 10 * time.Second | |||
| defaultUnpublishedOperationLifespan = time.Minute | |||
DRK3
force-pushed
the
ParametersForUnpublishedOperationLifespanAndExpiredDataCheckInterval
branch
from
3036271
to
da3a433
Compare
sandrask
approved these changes
Oct 15, 2021
Also added in the registration for the database timeout command line flag, which was missing (which meant that the environment variable would have been the only way to set it before. Now using the --database-timeout flag will work too) Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
ParametersForUnpublishedOperationLifespanAndExpiredDataCheckInterval
branch
from
da3a433
to
1203cd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added in the registration for the database timeout command line flag, which was missing (which meant that the environment variable would have been the only way to set it before. Now using the --database-timeout flag will work too)
closes #808
Signed-off-by: Derek Trider Derek.Trider@securekey.com