Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix resource id for non-create operations #820

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

sandrask
Copy link
Contributor

For non-create operations we should use multihash from previous anchor (e.g. did:orb:uXXX:suffix)

Closes #819

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #820 (b3b8ffe) into main (5c3ec86) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   89.44%   89.52%   +0.07%     
==========================================
  Files         144      144              
  Lines       12602    12615      +13     
==========================================
+ Hits        11272    11293      +21     
+ Misses        821      814       -7     
+ Partials      509      508       -1     
Impacted Files Coverage Δ
...event/generator/didorbgenerator/didorbgenerator.go 83.49% <100.00%> (-0.32%) ⬇️
pkg/observer/pubsub.go 94.44% <0.00%> (ø)
cmd/orb-server/startcmd/start.go 74.02% <0.00%> (+0.03%) ⬆️
pkg/store/operation/unpublished/store.go 92.72% <0.00%> (+0.13%) ⬆️
cmd/orb-server/startcmd/params.go 81.05% <0.00%> (+0.51%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 100.00% <0.00%> (+9.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c3ec86...b3b8ffe. Read the comment docs.

For non-create operations we should use multihash from previous anchor (e.g. did:orb:uXXX:suffix)

Closes trustbloc#819

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask changed the title fix: Fix resource id for non-create operations wip: Fix resource id for non-create operations Oct 15, 2021
@sandrask sandrask changed the title wip: Fix resource id for non-create operations fix: Fix resource id for non-create operations Oct 18, 2021
@fqutishat fqutishat merged commit d179dec into trustbloc:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix resource id for non-create operations
3 participants