Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make anchor credential param optional and add default value #821

Merged
merged 1 commit into from
Oct 18, 2021
Merged

chore: make anchor credential param optional and add default value #821

merged 1 commit into from
Oct 18, 2021

Conversation

fqutishat
Copy link
Contributor

Signed-off-by: Firas Qutishat firas.qutishat@securekey.com

@cla-bot cla-bot bot added the cla-signed label Oct 18, 2021
Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #821 (132618d) into main (d179dec) will increase coverage by 0.03%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
+ Coverage   89.45%   89.49%   +0.03%     
==========================================
  Files         144      144              
  Lines       12615    12615              
==========================================
+ Hits        11285    11290       +5     
+ Misses        821      815       -6     
- Partials      509      510       +1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/params.go 79.83% <45.45%> (-1.23%) ⬇️
pkg/observer/pubsub.go 97.22% <0.00%> (+2.77%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 100.00% <0.00%> (+9.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d179dec...132618d. Read the comment docs.

@fqutishat fqutishat merged commit 472962a into trustbloc:main Oct 18, 2021
@fqutishat fqutishat deleted the update branch October 18, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants