Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make previous anchors list instead of map #823

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

sandrask
Copy link
Contributor

Make previous anchors list instead of map in order to have consistent running of unit-test. This change will also make it easier if we decide to support shortcut indexing.

Closes #607

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

Make previous anchors list instead of map in order to have consistent running of unit-test. This change will also make it easier if we decide to support shortcut indexing.

Closes trustbloc#607

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #823 (a6736cc) into main (b3b8ffe) will decrease coverage by 0.08%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   89.52%   89.43%   -0.09%     
==========================================
  Files         144      144              
  Lines       12615    12620       +5     
==========================================
- Hits        11293    11287       -6     
- Misses        814      822       +8     
- Partials      508      511       +3     
Impacted Files Coverage Δ
...event/generator/didorbgenerator/didorbgenerator.go 83.49% <93.75%> (ø)
pkg/anchor/anchorevent/anchorevent.go 78.33% <100.00%> (ø)
pkg/anchor/graph/graph.go 84.90% <100.00%> (+1.57%) ⬆️
pkg/anchor/writer/writer.go 91.59% <100.00%> (ø)
pkg/observer/observer.go 81.77% <100.00%> (ø)
...pub/service/inbox/httpsubscriber/httpsubscriber.go 90.12% <0.00%> (-9.88%) ⬇️
cmd/orb-server/startcmd/params.go 79.83% <0.00%> (-1.23%) ⬇️
pkg/observer/pubsub.go 97.22% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b8ffe...a6736cc. Read the comment docs.

@fqutishat fqutishat merged commit c826bc5 into trustbloc:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make previous anchors list instead of map
3 participants