feat: Verifiable Credential REST #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Verifiable Credential REST Closes trustbloc#431 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #829 +/- ##
==========================================
- Coverage 89.39% 89.36% -0.03%
==========================================
Files 144 145 +1
Lines 12725 12755 +30
==========================================
+ Hits 11375 11399 +24
- Misses 832 836 +4
- Partials 518 520 +2
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Oct 21, 2021
DRK3
approved these changes
Oct 21, 2021
|
|
||
| if len(body) > 0 { | ||
| if _, err := w.Write(body); err != nil { | ||
| logger.Warnf("[%s] Unable to write response: %s", err) |
There was a problem hiding this comment.
This should probably be logger.Errorf
There was a problem hiding this comment.
I have similar code in other handlers. Also, Bob chose Warnf in his handlers. I don't think it matters too much - we can discuss it and change it in all handler if necessary.
There was a problem hiding this comment.
Oh ok, better to be consistent then - not a major concern I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Verifiable Credential REST
Closes #431
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com