fix: Add signature validation for VC before processing Sidetree batches #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included: - remove unused PublicKeyFetcher from anchor/graph - add PublicKeyFetcher to observer and verify VC signatures Closes trustbloc#831 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 89.36% 89.43% +0.06%
==========================================
Files 145 145
Lines 12755 12754 -1
==========================================
+ Hits 11399 11406 +7
+ Misses 836 829 -7
+ Partials 520 519 -1
Continue to review full report at Codecov.
|
DRK3
approved these changes
Oct 22, 2021
fqutishat
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included:
Closes #831
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com