feat: Removal of Orb ID #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed Orb ID parameter since it's not needed. The DB expiry service now always uses a randomly generated ID. The warning that gets logged when the Orb ID wasn't explicitly set has also been removed. - Changed the log statement in the expiry service that informs when one server takes over the duty from another server from a warning to an info log. Since Orb instances are expected to potentially go offline or be replicated as needed, this seems more appropriate. The log message was also updated so that it doesn't state that this switching indicates an issue anymore. - Also removed an outdated TODO comment since it's been addressed already. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 89.37% 89.44% +0.06%
==========================================
Files 145 145
Lines 12758 12747 -11
==========================================
- Hits 11402 11401 -1
+ Misses 836 828 -8
+ Partials 520 518 -2
Continue to review full report at Codecov.
|
bstasyszyn
approved these changes
Oct 25, 2021
fqutishat
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Trider Derek.Trider@securekey.com