fix: Some expiry service unit tests failing intermittently #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRK3
force-pushed
the
FixIntermittentExpiryUnitTestFailures
branch
from
6cb37d7
to
f339af2
Compare
Some unit tests for the expiry service code relied on starting the service, waiting a short period of time, and then checking the logs to see if an expected failure message was logged. If a system is running slowly, these failure messages may not get logged in time, resulting in a failure. Now, the test will check the logs a maximum of 20 times (with a delay between each check) before giving up and concluding the test has failed. This allows the tests to pass on slower systems while still running quickly on faster machines. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
FixIntermittentExpiryUnitTestFailures
branch
from
f339af2
to
fd00666
Compare
Codecov Report
@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 89.37% 89.45% +0.08%
==========================================
Files 145 145
Lines 12758 12758
==========================================
+ Hits 11402 11413 +11
+ Misses 836 827 -9
+ Partials 520 518 -2
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Oct 25, 2021
bstasyszyn
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests for the expiry service code relied on starting the service, waiting a short period of time, and then checking the logs to see if an expected failure message was logged. If a system is running slowly, these failure messages may not get logged in time, resulting in a failure. Now, the test will check the logs a maximum of 20 times (with a delay between each check) before giving up and concluding the test has failed. This allows the tests to pass on slower systems while still running quickly on faster machines.
Signed-off-by: Derek Trider Derek.Trider@securekey.com