Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add bdd test for VC REST #839

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

sandrask
Copy link
Contributor

Add bdd test for VC REST.

Closes #831

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

Add bdd test for VC REST.

Closes trustbloc#831

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #839 (91e8305) into main (ec99b50) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #839   +/-   ##
=======================================
  Coverage   89.43%   89.44%           
=======================================
  Files         145      145           
  Lines       12758    12747   -11     
=======================================
- Hits        11410    11401    -9     
+ Misses        829      828    -1     
+ Partials      519      518    -1     
Impacted Files Coverage Δ
pkg/activitypub/service/vct/vct.go 91.48% <ø> (ø)
pkg/anchor/builder/builder.go 100.00% <ø> (ø)
cmd/orb-server/startcmd/params.go 79.88% <0.00%> (-0.05%) ⬇️
pkg/observer/pubsub.go 94.44% <0.00%> (ø)
cmd/orb-server/startcmd/start.go 73.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c039f...91e8305. Read the comment docs.

@bstasyszyn bstasyszyn merged commit d218311 into trustbloc:main Oct 26, 2021
@sandrask sandrask linked an issue Oct 26, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix VC signature validation (observer) BDD Test for Verifiable Credential REST
3 participants