Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Select minimum number of witnesses based on policy #868

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

sandrask
Copy link
Contributor

Batch writer should select minimum number of witnesses based on policy.
First selector will be random selector.

Closes #866

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

Batch writer should select minimum number of witnesses based on policy.
First selector will be random selector.

Closes trustbloc#866

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #868 (fd54d97) into main (1d530d8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   89.32%   89.34%   +0.01%     
==========================================
  Files         151      153       +2     
  Lines       13494    13587      +93     
==========================================
+ Hits        12054    12139      +85     
- Misses        886      893       +7     
- Partials      554      555       +1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 73.01% <100.00%> (+0.03%) ⬆️
pkg/anchor/witness/policy/config/parser.go 95.12% <100.00%> (+0.18%) ⬆️
pkg/anchor/witness/policy/policy.go 98.38% <100.00%> (+1.24%) ⬆️
.../anchor/witness/policy/selector/random/selector.go 100.00% <100.00%> (ø)
pkg/anchor/witness/proof/proof.go 100.00% <100.00%> (ø)
pkg/anchor/writer/writer.go 91.50% <100.00%> (+0.24%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 90.12% <0.00%> (-9.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecebebb...fd54d97. Read the comment docs.

@fqutishat fqutishat merged commit 5524fe4 into trustbloc:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select minimum witnesses based on policy
4 participants