Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added 'accept list' management command to orb-cli #870

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

bstasyszyn
Copy link
Contributor

Added an 'acceptlist' command to orb-cli that manages accept lists that are used by the 'Follow' and 'Invite' witness authorization handlers. The command has three sub-commands:

  • add - Adds one or more actor URIs to the accept list of a given type (follow or invite-witness)
  • remove - Removes one or more actor URIs from the accept list of a given type (follow or invite-witness)
  • get - Retrieves all accept lists or an accept list of a specified type (follow or invite-witness)

closes #865

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

Added an 'acceptlist' command to orb-cli that manages accept lists that are used by the 'Follow' and 'Invite' witness authorization handlers. The command has three sub-commands:

- add - Adds one or more actor URIs to the accept list of a given type (follow or invite-witness)
- remove - Removes one or more actor URIs from the accept list of a given type (follow or invite-witness)
- get - Retrieves all accept lists or an accept list of a specified type (follow or invite-witness)

closes trustbloc#865

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #870 (90084f7) into main (1d530d8) will decrease coverage by 0.07%.
The diff coverage is 88.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   89.32%   89.25%   -0.08%     
==========================================
  Files         151      154       +3     
  Lines       13494    13637     +143     
==========================================
+ Hits        12054    12172     +118     
- Misses        886      903      +17     
- Partials      554      562       +8     
Impacted Files Coverage Δ
pkg/activitypub/service/acceptlist/acceptlist.go 87.28% <ø> (-0.11%) ⬇️
cmd/orb-cli/common/common.go 79.55% <76.92%> (-0.73%) ⬇️
cmd/orb-cli/acceptlistcmd/getcmd.go 86.20% <86.20%> (ø)
cmd/orb-cli/acceptlistcmd/updatecmd.go 93.44% <93.44%> (ø)
cmd/orb-cli/acceptlistcmd/acceptlist.go 100.00% <100.00%> (ø)
cmd/orb-cli/main.go 73.33% <100.00%> (+0.91%) ⬆️
pkg/store/witness/witness.go 86.20% <0.00%> (-4.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecebebb...90084f7. Read the comment docs.

@fqutishat fqutishat merged commit d030b87 into trustbloc:main Nov 11, 2021
@bstasyszyn bstasyszyn deleted the 865 branch November 11, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'accept list' management functions to Orb CLI
3 participants