chore: Optimize selection of system and batch witnesses #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize selection of batch and system witnesses by using common witnesses. If there is an intersection between eligible batch witnesses set and eligible system witnesses set use those first during witnesses selection if witness policy is an AND policy. Closes trustbloc#869 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 89.27% 89.40% +0.13%
==========================================
Files 156 156
Lines 13730 13758 +28
==========================================
+ Hits 12257 12301 +44
+ Misses 910 896 -14
+ Partials 563 561 -2
Continue to review full report at Codecov.
|
bstasyszyn
approved these changes
Nov 11, 2021
fqutishat
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize selection of batch and system witnesses by using common witnesses. If there is an intersection between eligible batch witnesses set and eligible system witnesses set then use those common witnesses first during witnesses selection (if witness policy is an AND policy).
Closes #869
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com